Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

[Stuart Brady]

On Tue, May 04, 2010 at 10:51:37PM +0200, Sebastian Herbszt wrote:
> >diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> >index fe7a121..4d4de93 100644
> >--- a/hw/pci_ids.h
> >+++ b/hw/pci_ids.h
> >@@ -97,3 +97,4 @@
> >#define PCI_DEVICE_ID_INTEL_82371AB      0x7111
> >#define PCI_DEVICE_ID_INTEL_82371AB_2    0x7112
> >#define PCI_DEVICE_ID_INTEL_82371AB_3    0x7113
> >+#define PCI_DEVICE_ID_INTEL_ICH6R_AHCI    0x2652
> 
> The list is sorted by vendor and device id. This entry should go
> after "PCI_DEVICE_ID_INTEL_ESB_9". The naming scheme seems
> to be VENDOR_DEVICE_FUNCTION, so i suggest something like
> PCI_DEVICE_ID_INTEL_ICH6R_2 or PCI_DEVICE_ID_INTEL_82801FR_2.

Linux seems to have called this PCI_DEVICE_ID_INTEL_ICH6_4 at one point.

So this should be function 4, no?

Cheers,
-- 
Stuart Brady