[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ide: Fix ide_dma_cancel
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH] ide: Fix ide_dma_cancel |
|
Date: |
Wed, 5 May 2010 20:48:47 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Wed, May 05, 2010 at 11:54:56AM +0200, Kevin Wolf wrote:
> When cancelling a request, bdrv_aio_cancel may decide that it waits for
> completion of a request rather than for cancellation. IDE therefore can't
> abandon its DMA status before calling bdrv_aio_cancel; otherwise the callback
> of a completed request would use invalid data.
>
> Signed-off-by: Kevin Wolf <address@hidden>
As mentioned before, looks good.
Reviewed-by: Christoph Hellwig <address@hidden>