[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion |
Date: |
Tue, 04 May 2010 14:20:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
Am 04.05.2010 13:38, schrieb Peter Lieven:
> hi kevin,
>
> i set a breakpint at bmdma_active_if. the first 2 breaks encountered
> when the last path in the multipath
> failed, but the assertion was not true.
> when i kicked one path back in the breakpoint was reached again, this
> time leading to an assert.
> the stacktrace is from the point shortly before.
>
> hope this helps.
Hm, looks like there's something wrong with cancelling requests -
bdrv_aio_cancel might decide that it completes a request (and
consequently calls the callback for it) whereas the IDE emulation
decides that it's done with the request before calling bdrv_aio_cancel.
I haven't looked in much detail what this could break, but does
something like this help?
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 0757528..3cd55e3 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2838,10 +2838,6 @@ static void ide_dma_restart(IDEState *s, int is_read)
void ide_dma_cancel(BMDMAState *bm)
{
if (bm->status & BM_STATUS_DMAING) {
- bm->status &= ~BM_STATUS_DMAING;
- /* cancel DMA request */
- bm->unit = -1;
- bm->dma_cb = NULL;
if (bm->aiocb) {
#ifdef DEBUG_AIO
printf("aio_cancel\n");
@@ -2849,6 +2845,10 @@ void ide_dma_cancel(BMDMAState *bm)
bdrv_aio_cancel(bm->aiocb);
bm->aiocb = NULL;
}
+ bm->status &= ~BM_STATUS_DMAING;
+ /* cancel DMA request */
+ bm->unit = -1;
+ bm->dma_cb = NULL;
}
}
Kevin
- [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Peter Lieven, 2010/05/03
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Kevin Wolf, 2010/05/04
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Peter Lieven, 2010/05/04
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion,
Kevin Wolf <=
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Peter Lieven, 2010/05/04
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Kevin Wolf, 2010/05/04
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Christoph Hellwig, 2010/05/04
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Peter Lieven, 2010/05/18
- Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion, Kevin Wolf, 2010/05/18
- qemu-kvm hangs if multipath device is queing (was: Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion), Peter Lieven, 2010/05/12
- [Qemu-devel] Re: qemu-kvm hangs if multipath device is queing, Kevin Wolf, 2010/05/14
- [Qemu-devel] Re: qemu-kvm hangs if multipath device is queing, Peter Lieven, 2010/05/18
- [Qemu-devel] Re: qemu-kvm hangs if multipath device is queing, Kevin Wolf, 2010/05/18
- [Qemu-devel] Re: qemu-kvm hangs if multipath device is queing, Christoph Hellwig, 2010/05/19