[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

[Marcelo Tosatti]

On Mon, Apr 26, 2010 at 01:27:30PM -0500, Anthony Liguori wrote:
> On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
> >Which allows drivers to register an mmaped region into ram block mappings.
> >To be used by device assignment driver.
> 
> This doesn't make much sense to me.
> 
> Do you use this like:
> 
> qemu_ram_map(64k, ptr);
> assert(qemu_ram_alloc(64k) == ptr);

No. hw/device-assignment.c in qemu-kvm mmaps
/sys/bus/pci/devices/x:y:z/resourcen (the PCI devices memory regions) to
the guest.

> If so, I think this is not the best API.  I'd rather see
> qemu_ram_map() register a symbolic name for the region and for there
> to be a qemu_ram_alloc() variant that allocated by name.
> 
> Regards,
> 
> Anthony Liguori
>