qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG
Date: Wed, 21 Apr 2010 15:55:30 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4

  Hi,

* the SIZE property patch:    Msg-Id:<address@hidden>

Fine with me.

* the socket reconnect patch: Msg-Id:<address@hidden>

Not sure yet.

If we can get these patches sorted out, the only outstanding issues are
where the EGD protocol support and rate limiting should go.

I think it makes sense to have a separate chardev backend for it, so you can easily hook it up to either virtio-rng or something else, i.e. define a chardev for the egd connection like this:

-chardev backend=egd,id=egd,server=$address,$rate-limit-options-here

then link it to virtio-rng ...

-device virtio-rng-pci,chardev=egd

... or virtio-serial ...

-device virtserialport,chardev=egd,name=org.qemu.egd

... or a emulated 16650 ....

-device isa-serial,chardev=egd

... depending on what you prefer and what your guest can handle.

It might make sense to have the reconnect logic in the egd chardev backend then, thereby obsoleting the socket reconnect patch.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]