[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] vmdk: Convert to bdrv_open
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] vmdk: Convert to bdrv_open |
Date: |
Mon, 19 Apr 2010 09:37:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
Am 17.04.2010 11:39, schrieb Stefan Hajnoczi:
> On Fri, Apr 16, 2010 at 8:59 PM, Kevin Wolf <address@hidden> wrote:
>> diff --git a/block/vmdk.c b/block/vmdk.c
>> index 781518a..27b6360 100644
>> --- a/block/vmdk.c
>> +++ b/block/vmdk.c
>> @@ -835,14 +828,12 @@ static void vmdk_close(BlockDriverState *bs)
>> qemu_free(s->l1_table);
>> qemu_free(s->l2_cache);
>> // try to close parent image, if exist
>> - vmdk_parent_close(s->hd);
>> - bdrv_delete(s->hd);
>> + vmdk_parent_close(bs->file);
>> }
>
> block.c:bdrv_close() calls bdrv_delete(bs->backing_hd) before
> bs->bdrv_close(). The vmdk format doesn't need to explicitly close
> its parent file and the vmdk_parent_close() function can be deleted.
> vmdk.c is the only block driver that explicitly closes or deletes
> backing_hd.
Right, I should have removed this code in patch 2/3. I'll fix that and
send a new version.
Kevin