[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] qemu-kvm: avoid strlen of NULL pointer
From: |
Jens Osterkamp |
Subject: |
[Qemu-devel] [PATCH v2] qemu-kvm: avoid strlen of NULL pointer |
Date: |
Mon, 12 Apr 2010 10:51:01 +0200 |
User-agent: |
KMail/1.10.4 (Linux/2.6.27-16-generic; KDE/4.1.4; i686; ; ) |
If the user wants to create a chardev of type socket but forgets to give a
host= option, qemu_opt_get returns NULL. This NULL pointer is then fed into
strlen a few lines below without a check which results in a segfault.
This fixes it.
Signed-off-by: Jens Osterkamp <address@hidden>
---
qemu-sockets.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qemu-sockets.c b/qemu-sockets.c
index 23c3def..87a79e5 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -130,7 +130,8 @@ int inet_listen_opts(QemuOpts *opts, int port_offset)
ai.ai_family = PF_UNSPEC;
ai.ai_socktype = SOCK_STREAM;
- if (qemu_opt_get(opts, "port") == NULL) {
+ if ((qemu_opt_get(opts, "port") == NULL) ||
+ (qemu_opt_get(opts, "host") == NULL)) {
fprintf(stderr, "%s: host and/or port not specified\n", __FUNCTION__);
return -1;
}
--
1.5.6.3
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH v2] qemu-kvm: avoid strlen of NULL pointer,
Jens Osterkamp <=