[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [STABLE][PATCH 08/10] block: Fix multiwrite memory leak in
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [STABLE][PATCH 08/10] block: Fix multiwrite memory leak in error case |
Date: |
Fri, 9 Apr 2010 11:46:26 +0200 |
Previously multiwrite_user_cb was never called if a request in the multiwrite
batch failed right away because it did set mcb->error immediately. Make it look
more like a normal callback to fix this.
Reported-by: Juan Quintela <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index d537d10..4f9a48b 100644
--- a/block.c
+++ b/block.c
@@ -1761,7 +1761,8 @@ int bdrv_aio_multiwrite(BlockDriverState *bs,
BlockRequest *reqs, int num_reqs)
reqs[i].error = -EIO;
goto fail;
} else {
- mcb->error = -EIO;
+ mcb->num_requests++;
+ multiwrite_cb(mcb, -EIO);
break;
}
} else {
--
1.6.6.1
- [Qemu-devel] [STABLE][PULL 00/10] Patches for 0.12.4, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 01/10] json-parser: Fix segfault on malformed input, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 02/10] block: avoid creating too large iovecs in multiwrite_merge, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 05/10] scsi-disk: fix buffer overflow, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 06/10] block: Fix multiwrite error handling, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 03/10] qcow2: Factor next_refcount_table_size out, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 04/10] qcow2: Rewrite alloc_refcount_block/grow_refcount_table, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 10/10] qcow2: Remove request from in-flight list after error, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 09/10] qcow2: Don't ignore immediate read/write failures, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 08/10] block: Fix multiwrite memory leak in error case,
Kevin Wolf <=
- [Qemu-devel] [STABLE][PATCH 07/10] block: Fix error code in multiwrite for immediate failures, Kevin Wolf, 2010/04/09
- Re: [Qemu-devel] [STABLE][PULL 00/10] Patches for 0.12.4, Aurelien Jarno, 2010/04/09