[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [STABLE][PATCH 09/10] qcow2: Don't ignore immediate read/wr
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [STABLE][PATCH 09/10] qcow2: Don't ignore immediate read/write failures |
Date: |
Fri, 9 Apr 2010 11:46:27 +0200 |
Returning -EIO is far from optimal, but at least it's an error code.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/qcow2.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 4ae8f19..f6f8980 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -467,8 +467,10 @@ static void qcow_aio_read_cb(void *opaque, int ret)
acb->hd_aiocb = bdrv_aio_readv(s->hd,
(acb->cluster_offset >> 9) + index_in_cluster,
&acb->hd_qiov, acb->n, qcow_aio_read_cb, acb);
- if (acb->hd_aiocb == NULL)
+ if (acb->hd_aiocb == NULL) {
+ ret = -EIO;
goto done;
+ }
}
return;
@@ -620,8 +622,10 @@ static void qcow_aio_write_cb(void *opaque, int ret)
(acb->cluster_offset >> 9) +
index_in_cluster,
&acb->hd_qiov, acb->n,
qcow_aio_write_cb, acb);
- if (acb->hd_aiocb == NULL)
+ if (acb->hd_aiocb == NULL) {
+ ret = -EIO;
goto done;
+ }
return;
--
1.6.6.1
- [Qemu-devel] [STABLE][PULL 00/10] Patches for 0.12.4, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 01/10] json-parser: Fix segfault on malformed input, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 02/10] block: avoid creating too large iovecs in multiwrite_merge, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 05/10] scsi-disk: fix buffer overflow, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 06/10] block: Fix multiwrite error handling, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 03/10] qcow2: Factor next_refcount_table_size out, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 04/10] qcow2: Rewrite alloc_refcount_block/grow_refcount_table, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 10/10] qcow2: Remove request from in-flight list after error, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 09/10] qcow2: Don't ignore immediate read/write failures,
Kevin Wolf <=
- [Qemu-devel] [STABLE][PATCH 08/10] block: Fix multiwrite memory leak in error case, Kevin Wolf, 2010/04/09
- [Qemu-devel] [STABLE][PATCH 07/10] block: Fix error code in multiwrite for immediate failures, Kevin Wolf, 2010/04/09
- Re: [Qemu-devel] [STABLE][PULL 00/10] Patches for 0.12.4, Aurelien Jarno, 2010/04/09