Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are compiled once

[Anthony Liguori]

On 04/02/2010 12:46 PM, Paolo Bonzini wrote:
> On 04/02/2010 07:36 PM, Anthony Liguori wrote:
> > On 04/02/2010 11:43 AM, Paolo Bonzini wrote:
> > > On 04/02/2010 06:24 PM, Anthony Liguori wrote:
> > > > I'd rather things be compiled per-target than adding a bunch of crud
> > > > everywhere.
> > >
> > > Well, this patch in particular removes more lines than it adds. :-P
> > >
> > > Anyway---me too, given how hairy it's coming out. Maybe (or without
> > > maybe) this work should have been done on a branch.
> >
> > What files need to be compiled per-target to fix qemu-kvm?
>
> With this patch, pci.o/i8254.o/acpi.o.  Without, also pcspk.o and 
> acpi.o then I stopped.

i8254.o has to be a bug.  There should be no reason to include 
qemu-kvm.h there.  Likewise with acpi.o and pcspk.o.

Regards,

Anthony Liguori

> Paolo