Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened

[Luiz Capitulino]

On Thu, 1 Apr 2010 13:23:44 -0500
Ryan Harper <address@hidden> wrote:

> * Luiz Capitulino <address@hidden> [2010-04-01 13:17]:
> > On Thu, 25 Mar 2010 09:32:58 -0500
> > Ryan Harper <address@hidden> wrote:
> > 
> > > Currently when using the change command to switch the file in the cd drive
> > > the command doesn't complain if the file doesn't exit or can't be opened
> > > and the drive keeps the existing image.  This patch adds a qerror_report
> > > call to print a message out indicating the failure.  This error message
> > > can be used to catch failures.
> > 
> >  Looks good to me, but it doesn't keep the existing image, it will silently
> > eject it instead.
> 
> That's true, but that happens whether or not we indicate the change
> failed.  I think fixing that is a good idea, but it shouldn't part of
> this patch (just indicating the failure).

 Sure, this patch is good by itself.