[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and
[Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'
Wed, 31 Mar 2010 17:19:07 +0200
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
Markus Armbruster <address@hidden> wrote:
> Shahar Havivi <address@hidden> writes:
>> On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote:
>>> Since the index is not a stable identifier of keyboards, and we support
>>> multiple monitors, you're prone to remove the wrong keyboard.
>>> Monitor#1 Monitor#2
>>> "info keyboard" to find the index
>>> unplug a keyboard, invalidating
>>> keyboard_set <index>
>>> I think it's best to use a stable ID, like we do in other places. We
>>> commonly let the user specify it, e.g. as id=ID in -netdev, -device and
>> What do we do when user not specify id for device?
> Two obvious options: make one up (problem: clashes), or stipulate "if
> you want to keyboard_set this keyboard, you must specify an id for it".
Second one is simpler, so .....