[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and
From: |
Shahar Havivi |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord' |
Date: |
Wed, 31 Mar 2010 18:14:18 +0300 |
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Wed, Mar 31, 2010 at 05:10:22PM +0200, Markus Armbruster wrote:
> Date: Wed, 31 Mar 2010 17:10:22 +0200
> From: Markus Armbruster <address@hidden>
> To: Shahar Havivi <address@hidden>
> Cc: address@hidden
> Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands:
> 'keyboard_set' and 'info keybaord'
>
> Shahar Havivi <address@hidden> writes:
>
> > On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote:
> [...]
> >> Since the index is not a stable identifier of keyboards, and we support
> >> multiple monitors, you're prone to remove the wrong keyboard.
> >>
> >> Monitor#1 Monitor#2
> >> "info keyboard" to find the index
> >> unplug a keyboard, invalidating
> >> index
> >> keyboard_set <index>
> >>
> >> I think it's best to use a stable ID, like we do in other places. We
> >> commonly let the user specify it, e.g. as id=ID in -netdev, -device and
> >> elswhere.
> > What do we do when user not specify id for device?
>
> Two obvious options: make one up (problem: clashes), or stipulate "if
> you want to keyboard_set this keyboard, you must specify an id for it".
>
> [...]
How about static auto incremented id like the mouse does?