[Qemu-devel] Re: [PATCH] Replace calls of old bdrv_open

[Kevin Wolf]

Am 31.03.2010 15:08, schrieb Juan Quintela:
> Kevin Wolf <address@hidden> wrote:
>> What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
>> callers of the old function are converted to the new one. In some places they
>> even know the right format, so they should have used bdrv_open2 from the
>> beginning.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
> 
> I would preffer a:
> bdrv_open() like yours with assert(drv != NULL).
> 
> bdrv_open_guess() for the current behaviour with NULL drv argument.
> (name sucks but I can guet a better one at the momment).
> 
> Why?  because I would like to have an easy way to grep for all places
> that "guess" what driver should they use.  And as you found on the
> patch, several places knew it and where using it out of laziness.
> 
> If I can have my pony, your patch is better than current behaviour :)

Feel free to post a v2 that implements your version. :-)

Kevin