[Qemu-devel] Re: [PATCH] Elo touchpad 10 bytes emulator v2

[Ricardo Ribalda Delgado]

Hello Juan

  Thanks for your comments. About the indentation error... Do you have
some kind of auto indent script(like the kernel code has). It is
making me crazy trying to collaborate with a lot of projects an all of
them with different styles.

>
>> +#include <stdlib.h>
>> +#include "../qemu-common.h"
>> +#include "../qemu-char.h"
>> +#include "../console.h"
>
> You can remove the "../" from those, Makefile sets correct include paths
> for this to work.


Ok. I used the mssmouse.c as reference. I can change that. (I guess
that I should also replace "" with <>)

>
>> +    /*Move event*/
>> +    if (is_down&&buttons_state){
>> +         bytes[2]=0x2;
>
> Can we use some constant from that bytes[2] values? 0x1, 0x2 and 0x4
> don't look specially descriptive.

ok


> Why does the lenght of the FIFO changes here?  I think this change in
> independent of the rest of the patch (no knowledge about the 16550A to
> know if it should be 16 or 32).

I have to send a 2x10 bytes package, and it does not fit the the 16
bytes buffer.... Any other suggestion about how to do it?

>
> Later, Juan.
>

Thanks again for your comments

-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/