[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/6] error: Trim includes after "Move qemu_error
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] Re: [PATCH 1/6] error: Trim includes after "Move qemu_error & friends..." |
Date: |
Mon, 22 Mar 2010 09:38:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Fri, 19 Mar 2010 22:31:05 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>>
>> > On Wed, 17 Mar 2010 18:56:49 +0100
>> > Markus Armbruster <address@hidden> wrote:
>> >
>> >> Missed in commit 2f792016.
>> >>
>> >> Signed-off-by: Markus Armbruster <address@hidden>
>> >> ---
>> >> hw/qdev-properties.c | 1 +
>> >> monitor.c | 2 --
>> >> sysemu.h | 2 --
>> >> 3 files changed, 1 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
>> >> index 92d6793..157a111 100644
>> >> --- a/hw/qdev-properties.c
>> >> +++ b/hw/qdev-properties.c
>> >> @@ -1,6 +1,7 @@
>> >> #include "sysemu.h"
>> >> #include "net.h"
>> >> #include "qdev.h"
>> >> +#include "qerror.h"
>> >>
>> >> void *qdev_get_prop_ptr(DeviceState *dev, Property *prop)
>> >> {
>> >> diff --git a/monitor.c b/monitor.c
>> >> index 0448a70..822dc27 100644
>> >> --- a/monitor.c
>> >> +++ b/monitor.c
>> >> @@ -49,10 +49,8 @@
>> >> #include "qint.h"
>> >> #include "qfloat.h"
>> >> #include "qlist.h"
>> >> -#include "qdict.h"
>> >> #include "qbool.h"
>> >> #include "qstring.h"
>> >> -#include "qerror.h"
>> >> #include "qjson.h"
>> >> #include "json-streamer.h"
>> >> #include "json-parser.h"
>> >> diff --git a/sysemu.h b/sysemu.h
>> >> index 8a9c630..9d3d51d 100644
>> >
>> > Hmm, why this second hunk? Also note that we have qemu-objects.h.
>>
>> The one below or the one above?
>
> The one above, but I believe it's because monitor.h includes them,
> right? This is fine.
Right.
[...]
[Qemu-devel] [PATCH 6/6] error: Move qerror_report() from qemu-error.[ch] to qerror.[ch], Markus Armbruster, 2010/03/17
[Qemu-devel] [PATCH 4/6] error: Make use of error_set_progname() optional, Markus Armbruster, 2010/03/17
[Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Markus Armbruster, 2010/03/17
- Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Blue Swirl, 2010/03/17
- Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Markus Armbruster, 2010/03/17
- Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Blue Swirl, 2010/03/18
- Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Markus Armbruster, 2010/03/18
- Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Blue Swirl, 2010/03/18
- Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Markus Armbruster, 2010/03/18
- Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o, Blue Swirl, 2010/03/18