[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open |
Date: |
Sat, 20 Mar 2010 08:01:49 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Ryota Ozaki <address@hidden> writes:
> bdrv_open may return -errno so we have to check
> if the return value is '< 0', not '== -1'.
>
> Signed-off-by: Ryota Ozaki <address@hidden>
> ---
> qemu-nbd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index a393583..b89c361 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -333,7 +333,7 @@ int main(int argc, char **argv)
> if (bs == NULL)
> return 1;
>
> - if (bdrv_open(bs, argv[optind], flags) == -1)
> + if (bdrv_open(bs, argv[optind], flags) < 0)
> return 1;
>
> fd_size = bs->total_sectors * 512;
Same bug in qemu-io.c. Could you fix that as well?