[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test |
Date: |
Thu, 18 Mar 2010 10:47:08 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Thu, Mar 18, 2010 at 09:26:10AM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
> > On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote:
> >> We already do the test for msix on the caller, just use that test
> >>
> >> Signed-off-by: Juan Quintela <address@hidden>
> >
> > NAK
> >
> > I think we are better off not making assumptions
> > about caller behaviour in msix.c, virtio
> > will not be the only user forever.
>
> That makes migration testing more difficult. Basically we are testing
> if we are using msix in two places. Obvious thing is:
> - we don't test in msix_save() if msix is used.
> - we don't test it in virtio_pci_save_config()
>
> I don't care if it is one way or another, but requiring to check it in
> the caller and the callee is a bit too much for me.
>
> Later, Juan.
msix does not require the check in the caller, by design it is
safe to call msix_save when msix is not present.
--
MST
- [Qemu-devel] [PATCH 2/9] virtio: Teach virtio-balloon about DO_UPCAST, (continued)
- [Qemu-devel] [PATCH 2/9] virtio: Teach virtio-balloon about DO_UPCAST, Juan Quintela, 2010/03/16
- [Qemu-devel] [PATCH 3/9] virtio: Teach virtio-blk about DO_UPCAST, Juan Quintela, 2010/03/16
- [Qemu-devel] [PATCH 5/9] virtio: Use DO_UPCAST instead of a cast, Juan Quintela, 2010/03/16
- [Qemu-devel] [PATCH 7/9] QLIST: Introduce QLIST_COPY_HEAD, Juan Quintela, 2010/03/16
- [Qemu-devel] [PATCH 6/9] virtio-pci: Remove duplicate test, Juan Quintela, 2010/03/16
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test, Michael S. Tsirkin, 2010/03/18
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test, Juan Quintela, 2010/03/18
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test,
Michael S. Tsirkin <=
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test, Juan Quintela, 2010/03/18
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test, Michael S. Tsirkin, 2010/03/18
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test, Juan Quintela, 2010/03/18
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test, Michael S. Tsirkin, 2010/03/18
- [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test, Juan Quintela, 2010/03/18
[Qemu-devel] [PATCH 4/9] virtio: Teach virtio-net about DO_UPCAST, Juan Quintela, 2010/03/16
[Qemu-devel] [PATCH 8/9] virtio-blk: change rq type to VirtIOBlockReq, Juan Quintela, 2010/03/16
[Qemu-devel] [PATCH 9/9] virtio-blk: use QLIST for the list of requests, Juan Quintela, 2010/03/16