Re: [Qemu-devel] [PATCH] load_elf: replace the address addend by a translation function

[Aurelien Jarno]

Thanks for the review.

On Sun, Mar 14, 2010 at 09:59:44PM +0000, Paul Brook wrote:
> > The patch also convert all machines that have an addend, simplify the
> > PowerPC kernel loading 
> 
> The new PPC code looks like it may break images > 16M in size.

The idea was to get rid of the most significant byte, as it changes
depending on the kernel version, while we want the kernel to be loaded
at a fixed address. Looks like I have to shift the mask by four bits.

> > and fix the MIPS kernel loading using this new
> > feature.
> 
> I'm fairly sure the MIPS routines are not board specific, so it'd be nice if 
> we could avoid the duplication.  This would also reduce pain if we implement 
> loading to other segments (in particular kseg1 and xkphys).
> 

Good idea.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net