qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCHv3 19/20] eepro100: Remove C++ comments


From: Michael S. Tsirkin
Subject: [Qemu-devel] Re: [PATCHv3 19/20] eepro100: Remove C++ comments
Date: Wed, 3 Mar 2010 21:59:45 +0200
User-agent: Mutt/1.5.19 (2009-01-05)

On Wed, Mar 03, 2010 at 08:15:09PM +0100, Stefan Weil wrote:
> Michael S. Tsirkin schrieb:
> > On Tue, Mar 02, 2010 at 10:37:59PM +0100, Stefan Weil wrote:
> >> C++ comments are unwanted, so this is fixed here.
> >>
> >> * Replace C++ comments by C comments.
> >> * Put code which was deactivated by a C++ comment in #if 0...#endif.
> >>
> >> Signed-off-by: Stefan Weil <address@hidden>
> >
> > It would be nice to add some documentation to commented
> > blocks, explaining why we still keep them around
> > and what happens if they are uncommented.
> 
> 
> Typically, later patches either use this deactivated code (maybe after
> some modifications), or they remove it completely. More documentation
> would help of course - I'll try my best :-)
> 
> The purpose of this patch was only elimination of C++ comments by formally
> transforming them to either C comments or by using the preprocessor #if.

Yes, I understand that.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]