[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 13/48] error: Make qemu_error() add a newlin
Re: [Qemu-devel] [PATCH RFC 13/48] error: Make qemu_error() add a newline, strip it from arguments
Mon, 01 Mar 2010 09:55:18 +0100
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
Luiz Capitulino <address@hidden> writes:
> On Wed, 24 Feb 2010 18:55:25 +0100
> Markus Armbruster <address@hidden> wrote:
>> This fixes a few error messages lacking a newline:
>> net_handle_fd_param()'s "No file descriptor named %s found", and
>> tap_open()'s "vnet_hdr=1 requested, but no kernel support for
>> IFF_VNET_HDR available" (all three versions).
>> There's one place that passes arguments without newlines
>> intentionally: load_vmstate(). Fix it up.
> I'm not a big fun of printing functions that add automatic newline,
> specially in C. But I understand that you're doing this because you're
> going to prefix some info to the printed string.
> In this case, you could rename the function to qemu_error_nl(). Or at
> least document it properly in the function definition.
Fair enough, I'll document it.
|[Prev in Thread]
||[Next in Thread]|
- Re: [Qemu-devel] [PATCH RFC 13/48] error: Make qemu_error() add a newline, strip it from arguments,
Markus Armbruster <=