[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC 03/48] usb: Remove disabled monitor_printf() in
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH RFC 03/48] usb: Remove disabled monitor_printf() in usb_read_file() |
Date: |
Wed, 24 Feb 2010 18:55:15 +0100 |
The monitor_printf() reports failure. Printing is wrong, because the
caller tries various arguments, and expects the function to fail for
some or all.
Disabled since commit 26a9e82a. Remove it.
Signed-off-by: Markus Armbruster <address@hidden>
---
usb-linux.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index a9c15c6..d0d7cff 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -1188,9 +1188,6 @@ static int usb_host_scan_dev(void *opaque, USBScanFunc
*func)
*/
static int usb_host_read_file(char *line, size_t line_size, const char
*device_file, const char *device_name)
{
-#if 0
- Monitor *mon = cur_mon;
-#endif
FILE *f;
int ret = 0;
char filename[PATH_MAX];
@@ -1201,11 +1198,6 @@ static int usb_host_read_file(char *line, size_t
line_size, const char *device_f
if (f) {
ret = fgets(line, line_size, f) != NULL;
fclose(f);
-#if 0
- } else {
- if (mon)
- monitor_printf(mon, "husb: could not open %s\n", filename);
-#endif
}
return ret;
--
1.6.6
- [Qemu-devel] [PATCH RFC 40/48] error: New QERR_NO_BUS_FOR_DEVICE, (continued)
- [Qemu-devel] [PATCH RFC 40/48] error: New QERR_NO_BUS_FOR_DEVICE, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 45/48] qemu-option: Rename find_list() to qemu_find_opts() & external linkage, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 37/48] error: New QERR_BAD_BUS_FOR_DEVICE, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 23/48] qdev: Factor qdev_create_from_info() out of qdev_create(), Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 36/48] error: New error_printf_unless_qmp(), Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 19/48] error: Track locations in configuration files, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 47/48] monitor: Use argument type 'O' for device_add, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 31/48] error: New QERR_BUS_NOT_FOUND, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 27/48] error: New QERR_PROPERTY_NOT_FOUND, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 29/48] qdev: convert setting device properties to QError, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 03/48] usb: Remove disabled monitor_printf() in usb_read_file(),
Markus Armbruster <=
- [Qemu-devel] [PATCH RFC 10/48] error: Simplify error sink setup, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 39/48] error: New QERR_DEVICE_INIT_FAILED, Markus Armbruster, 2010/02/24
- [Qemu-devel] [PATCH RFC 04/48] savevm: Fix -loadvm to report errors to stderr, not the monitor, Markus Armbruster, 2010/02/24
- [Qemu-devel] Re: [PATCH RFC 00/48] Convert device_add to QObject / QError, Michael S. Tsirkin, 2010/02/25
- Re: [Qemu-devel] [PATCH RFC 00/48] Convert device_add to QObject / QError, Luiz Capitulino, 2010/02/26