[Qemu-devel] Re: [PATCH 1/2] macvtap: rework object lifetime rules

[Ed Swierk]

On Sat, Feb 13, 2010 at 2:33 AM, Arnd Bergmann <address@hidden> wrote:
> The original macvtap code has a number of problems
> resulting from the use of RCU for protecting the
> access to struct macvtap_queue from open files.
>
> This includes
> - need for GFP_ATOMIC allocations for skbs
> - potential deadlocks when copy_*_user sleeps
> - inability to work with vhost-net
>
> Changing the lifetime of macvtap_queue to always
> depend on the open file solves all these. The
> RCU reference simply moves one step down to
> the reference on the macvlan_dev, which we
> only need for nonblocking operations.
>
> Signed-off-by: Arnd Bergmann <address@hidden>

This works for me.

Acked-by: Ed Swierk <address@hidden>