qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 2/4] qemu-kvm: morph io_thread_wakeup into qemu.git'


From: Paolo Bonzini
Subject: [Qemu-devel] [PATCH 2/4] qemu-kvm: morph io_thread_wakeup into qemu.git's qemu_event_read
Date: Thu, 11 Feb 2010 00:09:14 +0100

Again, no need to loop if less than a full buffer is read, the next
read would return EAGAIN.

Signed-off-by: Paolo Bonzini <address@hidden>
---
 qemu-kvm.c |   16 +++++-----------
 1 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/qemu-kvm.c b/qemu-kvm.c
index 669a784..50e1303 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -2049,19 +2049,13 @@ static void sigfd_handler(void *opaque)
 static void io_thread_wakeup(void *opaque)
 {
     int fd = (unsigned long) opaque;
-    char buffer[4096];
-
-    /* Drain the pipe/(eventfd) */
-    while (1) {
-        ssize_t len;
+    ssize_t len;
+    char buffer[512];
 
+    /* Drain the notify pipe.  For eventfd, only 8 bytes will be read.  */
+    do {
         len = read(fd, buffer, sizeof(buffer));
-        if (len == -1 && errno == EINTR)
-            continue;
-
-        if (len <= 0)
-            break;
-    }
+    } while ((len == -1 && errno == EINTR) || len == sizeof(buffer));
 }
 
 int kvm_main_loop(void)
-- 
1.6.6






reply via email to

[Prev in Thread] Current Thread [Next in Thread]