qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback


From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API
Date: Sun, 07 Feb 2010 16:32:27 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1

On 02/07/2010 04:26 PM, Jan Kiszka wrote:

Well, to me it makes more sense to name them from the point of view of
the vcpu that is doing the update.
I'm open for a better name - except for "sync" as writebacks are always
synchronous from the POV of the modified VCPU.

I meant that the state itself is synchronous from the POV of the vcpu. That is, rax can only be changed by the core, but INIT state may be changed by the other cores.

  Is KVM_PUT_RUNTIME_STATE
clearer?

They're all runtime. I guess this issue will always be confusing, so best to slap a comment on top of the define to explain it.

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]