[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id |
Date: |
Tue, 02 Feb 2010 15:33:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Gleb Natapov wrote:
> On Tue, Feb 02, 2010 at 03:20:02PM +0100, Jan Kiszka wrote:
>> Gleb Natapov wrote:
>>> On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote:
>>>> Setting the boot CPU ID is arch-specific KVM stuff. So push it where it
>>>> belongs to.
>>>>
>>> pc_init1 is also arch-specific, no? TCG should also be able to
>>> have BSP apic_id != 0.
>> But not kvm-specific.
>>
>> I don't understand your second remark. Can you help me how TCG is
>> affected by kvm_set_boot_cpu_id?
>>
> It is not affected right now. It assumes that apic ID of BSP cpu is 0,
> but this limitation does not exists on real HW. So when QEMU will be fixed
> and it will be possible to configure what CPU is BSP this will be the
> pace to do it.
That day pc_init1 (or whatever x86 part) will set the bsp number
somewhere in env or apicstate, and we will transfer that afterwards to kvm.
The point is that kvm_* belongs into kvm[-all].c as far as possible. And
in this case it is possible.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
[Qemu-devel] [PATCH 01/21] qemu-kvm: Drop vmport changes, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 18/21] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 17/21] qemu-kvm: Use VCPU event state for reset and vmsave/load, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 16/21] KVM: x86: Restrict writeback of VCPU state, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 09/21] qemu-kvm: Use upstream kvm_pit_in_kernel, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 10/21] KVM: Move and rename regs_modified, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 12/21] qemu-kvm: Use upstream kvm_vcpu_dirty, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 11/21] KVM: Rework of guest debug state writing, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 05/21] qemu-kvm: Use upstream kvm_enabled and cpu_synchronize_state, Jan Kiszka, 2010/02/02
[Qemu-devel] [PATCH 15/21] qemu-kvm: Clean up mpstate synchronization, Jan Kiszka, 2010/02/02