[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/8] QMP: Introduce qmp_capability_enable/disable
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 5/8] QMP: Introduce qmp_capability_enable/disable |
Date: |
Thu, 28 Jan 2010 11:42:57 -0200 |
As we don't have any capabilities yet, they always return an
InvalidParameter error.
Please, also note that:
o They don't accept an json-array yet, because this would require
not so simple changes and it's not useful right now
o We will need more infrastructure to have capabilities per Monitor,
which is not going to be done now as we don't need this yet either
Usage example:
{ "execute": "qmp_capability_enable", "arguments": { "name": "foo" } }
Signed-off-by: Luiz Capitulino <address@hidden>
---
monitor.c | 14 ++++++++++++++
qemu-monitor.hx | 30 ++++++++++++++++++++++++++++++
2 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index f6dd64d..9070a0c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -730,6 +730,20 @@ static void do_qmp_switch_mode(Monitor *mon, const QDict
*qdict,
}
}
+static void do_qmp_capability_enable(Monitor *mon, const QDict *qdict,
+ QObject **ret_data)
+{
+ /* QMP doesn't have any capabilities yet */
+ qemu_error_new(QERR_INVALID_PARAMETER, "name");
+}
+
+static void do_qmp_capability_disable(Monitor *mon, const QDict *qdict,
+ QObject **ret_data)
+{
+ /* QMP doesn't have any capabilities yet */
+ qemu_error_new(QERR_INVALID_PARAMETER, "name");
+}
+
/**
* do_info_commands(): List QMP available commands
*
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 29155ce..8905986 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -1079,6 +1079,36 @@ STEXI
Switch QMP to @var{mode}
ETEXI
+ {
+ .name = "qmp_capability_enable",
+ .args_type = "name:s",
+ .params = "name",
+ .help = "enable a QMP capability",
+ .flags = HANDLER_HANDSHAKE_ONLY,
+ .user_print = monitor_user_noop,
+ .mhandler.cmd_new = do_qmp_capability_enable,
+ },
+
+STEXI
address@hidden qmp_capability_enable @var{name}
+Enable QMP capability @{name}
+ETEXI
+
+ {
+ .name = "qmp_capability_disable",
+ .args_type = "name:s",
+ .params = "name",
+ .help = "disable a QMP capability",
+ .flags = HANDLER_HANDSHAKE_ONLY,
+ .user_print = monitor_user_noop,
+ .mhandler.cmd_new = do_qmp_capability_disable,
+ },
+
+STEXI
address@hidden qmp_capability_disable @var{name}
+Disable QMP capability @{name}
+ETEXI
+
STEXI
@end table
ETEXI
--
1.6.6
- [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support, Luiz Capitulino, 2010/01/28
- [Qemu-devel] [PATCH 1/8] QMP: Initial mode-oriented support, Luiz Capitulino, 2010/01/28
- [Qemu-devel] [PATCH 2/8] QMP: Introduce 'query-qmp-mode' command, Luiz Capitulino, 2010/01/28
- [Qemu-devel] [PATCH 3/8] QError: Add QMP mode-oriented errors, Luiz Capitulino, 2010/01/28
- [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command, Luiz Capitulino, 2010/01/28
- [Qemu-devel] [PATCH 5/8] QMP: Introduce qmp_capability_enable/disable,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 7/8] QMP: Enable feature negotiation support, Luiz Capitulino, 2010/01/28
- [Qemu-devel] [PATCH 6/8] Monitor: Introduce find_info_cmd(), Luiz Capitulino, 2010/01/28
- [Qemu-devel] [PATCH 8/8] QMP: spec: Feature negotiation related changes, Luiz Capitulino, 2010/01/28