qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating t


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs
Date: Tue, 26 Jan 2010 07:08:20 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/26/2010 03:21 AM, Christoph Hellwig wrote:
On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote:
To underline that it's a backend/platform dependent thing: Your patch
breaks the mingw build for me.
Actually that's because mingw is the usual piece of crap and doesn't
actually have any of the vector support you can expect from a normal
Unix system.

I can either throw in an #ifdef IOV_MAX around the check or fake one up
for mingw.  Does any of the maintainers have a preference for either
variant?

grep for CONFIG_IOVEC in qemu-common.h and add a #define IOV_MAX.

mingw doesn't have iovec so we introduce a compat version.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]