[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support |
Date: |
Tue, 26 Jan 2010 09:53:25 -0200 |
On Mon, 25 Jan 2010 15:33:40 +0100
Markus Armbruster <address@hidden> wrote:
> Anthony Liguori <address@hidden> writes:
>
> > On 01/21/2010 03:09 PM, Luiz Capitulino wrote:
> >> """
> >> {"QMP": {"capabilities": ["async messages"]}}
> >>
> >> { "execute": "query-qmp-mode" }
> >> {"return": {"mode": "handshake"}}
> >>
> >> { "execute": "change", "arguments": { "device": "vnc", "target":
> >> "password", "arg": "1234" } }
> >> {"error": {"class": "QMPInvalidModeCommad", "desc": "The issued command is
> >> invalid in this mode", "data": {}}}
> >>
> >> { "execute": "async_msg_enable", "arguments": { "name": "STOP" } }
> >> {"return": {}}
> >>
> >
> > Maybe:
> >
> > enable-capability "async messages"
> > disable-capability "async messages"
> >
> > I think that's a bit more obvious and it means that a client doesn't
> > have to maintain a mapping of features -> enable functions. It's also
> > strange to use an enable command to disable something.
>
> Agree on both counts. But why two commands? Why not simply "capability
> NAME VALUE"? Works even for non-boolean capabilities. I'm not
> predicting we'll need such capabilities.
I slightly prefer two commands because that's probably how I'd
write it in a program (ie. two functions), also enabling/disabling
a group of features is a bit easier too, as we can use an array:
capability_enable [ "foo", "bar" ]
Now, only one command is not terrible difficult, but we would
have to accept an array of objects, like:
[ { "name": "foo", "enabled": true }, { "name": "bar", "enabled": true } ]
- [Qemu-devel] Re: [PATCH 08/11] QMP: Asynchronous messages enable/disable support, (continued)
- [Qemu-devel] [PATCH 09/11] Monitor: Introduce find_info_cmd(), Luiz Capitulino, 2010/01/21
- [Qemu-devel] [PATCH 10/11] QError: New QERR_QMP_INVALID_MODE_COMMAND, Luiz Capitulino, 2010/01/21
- [Qemu-devel] [PATCH 11/11] QMP: Enable feature negotiation support, Luiz Capitulino, 2010/01/21
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Markus Armbruster, 2010/01/22
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Anthony Liguori, 2010/01/22
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Markus Armbruster, 2010/01/25
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support,
Luiz Capitulino <=
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Jamie Lokier, 2010/01/26
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Luiz Capitulino, 2010/01/26
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Daniel P. Berrange, 2010/01/26
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Jamie Lokier, 2010/01/26
- Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support, Luiz Capitulino, 2010/01/26