[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

[Jes Sorensen]

On 01/25/10 17:58, Alexander Graf wrote:
> Howdy. Congratulations to the new mail address - looks neat ;-).

:-)

> Two comments:
>
> 1) I don't see how passing a single region is any help. I'd rather like to see 
> a device tree like table structure
> You'd get one variable for len of the table, one with the contents. So for a 
> universal reserved region specifier you'd get:
>
> <u64 base><u64 len>
>
> Then have len=2 and put data in the table:
>
> <u64 base1><u64 len1><u64 base2><u64 len2>
>
> That way we'd get 2 entries and the chance to enhance them later on. In fact, 
> it might even make sense to pass the whole table in such a form. That way qemu 
> generates all of the e820 tables and we can declare whatever we want. Just add 
> a type field in the table.

I am fine with having QEMU build the e820 tables completely if there is
a consensus to take that path.

> 2) Please inline patches. They showed up as attachments here, making them 
> really hard to comment on.

Sorry Thunderbug doesn't do that well, but they should be attached as
txt?

Cheers,
Jes