[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support |
Date: |
Mon, 25 Jan 2010 13:11:30 -0200 |
On Mon, 25 Jan 2010 16:33:02 +0200
Avi Kivity <address@hidden> wrote:
> On 01/25/2010 04:29 PM, Markus Armbruster wrote:
> >
> > I agree with Anthony that async message masking doesn't really affect
> > the protocol proper. We could pretend it does so we can let protocol
> > capability negotiation (which we need anyway) cover it. But I'm
> > certainly fine with keeping it separate.
> >
> > Whether we call it protocol or not, the question whether we should
> > permit changing the masks at any time is valid, I think. Permitting it
> > adds a bit of conceptual complexity, as a command disabling reporting of
> > an event can race with the event. But that's just giving clients some
> > more rope. I'm fine with that.
> >
>
> Without disagreeing with the rest (which means I'm just nit-picking),
> there's no race. Once the command that disables an event report returns
> to the caller, the event can no longer be reported.
I wouldn't call it a race, but if you don't want an event you'll have
to deal with it between mode change and masking.
Not a big deal, only confirms that clients are required to know how to
ignore events, even if masking is available (which I'm not going to
introduce).
- [Qemu-devel] [PATCH 04/11] QMP: Introduce qmp_switch_mode command, (continued)
- [Qemu-devel] [PATCH 04/11] QMP: Introduce qmp_switch_mode command, Luiz Capitulino, 2010/01/21
- [Qemu-devel] [PATCH 05/11] QMP: advertise asynchronous messages, Luiz Capitulino, 2010/01/21
- [Qemu-devel] [PATCH 06/11] QMP: Array-based async messages, Luiz Capitulino, 2010/01/21
- [Qemu-devel] [PATCH 07/11] QError: New QERR_ASYNC_MSG_NOT_FOUND, Luiz Capitulino, 2010/01/21
- [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Luiz Capitulino, 2010/01/21
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Avi Kivity, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Jamie Lokier, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Anthony Liguori, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Jamie Lokier, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Luiz Capitulino, 2010/01/25
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Markus Armbruster, 2010/01/25
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Luiz Capitulino, 2010/01/25
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Anthony Liguori, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Avi Kivity, 2010/01/24
- Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support, Anthony Liguori, 2010/01/24