qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] qdev: Add help for device properties


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: Add help for device properties
Date: Thu, 21 Jan 2010 18:28:21 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0

On 01/21/10 17:44, Markus Armbruster wrote:
Markus Armbruster<address@hidden>  writes:

-        fprintf(stderr, "property \"%s.%s\" not found\n",
-                dev->info->name, name);

+                    fprintf(stderr, "%s.%s\n", dev->info->name, props->name);
+                    props++;

One question, though: why print DRIVER.PROPNAME instead of just
PROPNAME?  You could still put DRIVER into the heading, say "Properties
of DRIVER:".

Probably for consistency with the error messages.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]