Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

[Markus Armbruster]

Juan Quintela <address@hidden> writes:

> Gleb Natapov <address@hidden> wrote:
>> On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote:
[...]
>>> diff --git a/block/vvfat.c b/block/vvfat.c
>>> index 063f731..df957e5 100644
>>> --- a/block/vvfat.c
>>> +++ b/block/vvfat.c
>>> @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s,
>>>      {
>>>     direntry_t* entry=array_get_next(&(s->directory));
>>>     entry->attributes=0x28; /* archive | volume label */
>>> -   snprintf((char*)entry->name,11,"QEMU VVFAT");
>>> +   memcpy(entry->name,"QEMU VVF",8);
>>> +   memcpy(entry->extension,"AT ",3);
>>>      }
>>> 
>> Before the change extension was initialized to "AT\0" after it is "AT "
>
> it was paolo who told to do that change.  entries are not 0 ended.
>
> that was his explanation.

Please mention this in the commit message.