[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 00/10] qcow2 error path fixes
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v2 00/10] qcow2 error path fixes |
Date: |
Wed, 20 Jan 2010 15:02:57 +0100 |
In qcow2 (and partly also in general block code), error handling doesn't quite
do what it should. In some places, errors are silently ignored. In other
places, the error code in not passed to the called but rather turned into
false, NULL or -EIO. Besides reporting the right error to the user, providing
the right error code is also important for werror=enospc (and possible some
more functions).
This patch series tries to fix the most obvious of them. Don't assume it's
complete and expect a second part some time in the future.
v2:
- Patch 1/10: Fix leakage of clusters and memory in error case
- Patch 8/10: Special-case length = 0 at Christoph's request to return 0
immediately
- Patch 10/10: Fix another memory leak
Kevin Wolf (10):
qcow2: Fix error handling in qcow2_grow_l1_table
qcow2: Fix error handling in qcow_save_vmstate
qcow2: Return 0/-errno in get_cluster_table
qcow2: Return 0/-errno in qcow2_alloc_cluster_offset
block: Return original error codes in bdrv_pread/write
qcow2: Fix error handling in grow_refcount_table
qcow2: Improve error handling in update_refcount
qcow2: Allow updating no refcounts
qcow2: Don't ignore update_refcount return value
qcow2: Don't ignore qcow2_alloc_clusters return value
block.c | 34 ++++++++++---------
block/qcow2-cluster.c | 87 ++++++++++++++++++++++++++++++++---------------
block/qcow2-refcount.c | 84 +++++++++++++++++++++++++++++++++++----------
block/qcow2-snapshot.c | 11 +++++-
block/qcow2.c | 41 ++++++++++++----------
block/qcow2.h | 4 +-
6 files changed, 176 insertions(+), 85 deletions(-)
- [Qemu-devel] [PATCH v2 00/10] qcow2 error path fixes,
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 01/10] qcow2: Fix error handling in qcow2_grow_l1_table, Kevin Wolf, 2010/01/20
- [Qemu-devel] [PATCH v2 02/10] qcow2: Fix error handling in qcow_save_vmstate, Kevin Wolf, 2010/01/20
- [Qemu-devel] [PATCH v2 03/10] qcow2: Return 0/-errno in get_cluster_table, Kevin Wolf, 2010/01/20
- [Qemu-devel] [PATCH v2 05/10] block: Return original error codes in bdrv_pread/write, Kevin Wolf, 2010/01/20
- [Qemu-devel] [PATCH v2 06/10] qcow2: Fix error handling in grow_refcount_table, Kevin Wolf, 2010/01/20
- [Qemu-devel] [PATCH v2 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset, Kevin Wolf, 2010/01/20
- [Qemu-devel] [PATCH v2 07/10] qcow2: Improve error handling in update_refcount, Kevin Wolf, 2010/01/20
- [Qemu-devel] [PATCH v2 08/10] qcow2: Allow updating no refcounts, Kevin Wolf, 2010/01/20