qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: Stop using "which" in ./configure


From: Paolo Bonzini
Subject: [Qemu-devel] Re: Stop using "which" in ./configure
Date: Wed, 20 Jan 2010 14:16:54 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/20/2010 01:49 PM, Juan Quintela wrote:
+      if prog_exist "awk" -a \
+         prog_exist "grep"; then

+  if prog_exist "texi2html" -a \
+     prog_exist "pod2man" ; then

-a is wrong here. BTW, it's evil for test too because its precedence rules WRT ! and -f/-n/-z/-x/etc. are broken.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]