[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating t
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs |
|
Date: |
Wed, 20 Jan 2010 12:37:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 |
Am 19.01.2010 22:15, schrieb Christoph Hellwig:
> If we go over the maximum number of iovecs support by syscall we get
> back EINVAL from the kernel which translate to I/O errors for the guest.
>
> Signed-off-by: Christoph Hellwig <address@hidden>
Is this really enough? We don't check for IOV_MAX in any other place, so
can't we get a too big request directly from virtio-blk?
What about handling it transparently in qemu_pwritev/preadv and
laio_submit? Logically, it's a limitation of the backend anyway and not
a generic restriction.
To underline that it's a backend/platform dependent thing: Your patch
breaks the mingw build for me.
Kevin