[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] Check for sdl-config before calling it
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] Re: [PATCH] Check for sdl-config before calling it |
Date: |
Sun, 17 Jan 2010 14:43:34 +0100 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090707) |
Måns Rullgård schrieb:
> Loïc Minier <address@hidden> writes:
>
>
>> Hi
>>
>> On systems were sdl-config isn't installed, ./configure triggers this
>> warning:
>> ./configure: 957: sdl-config: not found
>>
>> The attached patch fixes the warning for me.
>>
>> Thanks,
>> --
>> Loïc Minier
>>
>> From 94876939db7f46cf8d920e289d0d4f929d3b7df1 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <address@hidden>
>> Date: Sun, 17 Jan 2010 13:42:04 +0100
>> Subject: [PATCH] Check for sdl-config before calling it
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> Check whether sdl-config is available before calling it, otherwise
>> ./configure triggers a warning:
>> ./configure: 957: sdl-config: not found
>>
>> If neither the .pc file not sdl-config are present, disable SDL support.
>>
>> Signed-off-by: Loïc Minier <address@hidden>
>> ---
>> configure | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 5631bbb..450e1a2 100755
>> --- a/configure
>> +++ b/configure
>> @@ -993,9 +993,11 @@ fi
>> if $pkgconfig sdl --modversion >/dev/null 2>&1; then
>> sdlconfig="$pkgconfig sdl"
>> _sdlversion=`$sdlconfig --modversion 2>/dev/null | sed 's/[^0-9]//g'`
>> -else
>> +elif which sdl-config >/dev/null 2>&1; then
>> sdlconfig='sdl-config'
>> _sdlversion=`$sdlconfig --version | sed 's/[^0-9]//g'`
>> +else
>> + sdl=no
>> fi
>>
>
> "which" isn't a standard command. Would simply 2>/dev/null do the
> trick just as well? If you really need to test for the existence of
> something, use "type".
>
"which" is already used several times in configure,
so this would not make things worse.
A macro for all these tests might be a better solution.
And that macro should use "type" or "type -t".
Regards,
Stefan
- [Qemu-devel] [PATCH] Check for sdl-config before calling it, Loïc Minier, 2010/01/17
- [Qemu-devel] Re: [PATCH] Check for sdl-config before calling it, Måns Rullgård, 2010/01/17
- Re: [Qemu-devel] Re: [PATCH] Check for sdl-config before calling it,
Stefan Weil <=
- [Qemu-devel] Re: [PATCH] Check for sdl-config before calling it, Måns Rullgård, 2010/01/17
- [Qemu-devel] Stop using "which" in ./configure, Loïc Minier, 2010/01/19
- Re: [Qemu-devel] Stop using "which" in ./configure, Loïc Minier, 2010/01/19
- Re: [Qemu-devel] Stop using "which" in ./configure, Stefan Weil, 2010/01/19
- Re: [Qemu-devel] Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/19
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/20