[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix QEMU_WARN_UNUSED_RESULT
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix QEMU_WARN_UNUSED_RESULT |
|
Date: |
Fri, 15 Jan 2010 17:45:25 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Since commit 747bbdf7 QEMU_WARN_UNUSED_RESULT is never defined as it is
> conditional on a define from config-host.h which is included only later.
> Include that file earlier to get the warnings back.
>
> Reactivating it unfortunately leads to some warnings about unused qdev_init
> results. These calls are changed to qdev_init_nofail to avoid build failures.
>
> Signed-off-by: Kevin Wolf <address@hidden>
The use of qdev_init_nofail() is correct, because the relevant device
init methods can't fail.
Acked-by: Markus Armbruster <address@hidden>