Re: [Qemu-devel] Re: [PATCH] write option roms in pc-bios/

[Blue Swirl]

On Fri, Jan 8, 2010 at 10:26 AM, Paolo Bonzini <address@hidden> wrote:
>>>>>> This will wreak havoc on the tree since these are built by default and
>>>>>> they are replacing files in revision control.
>>>>> ... the next question is why are they (linuxboot.bin and multiboot.bin)
>>>>> in revision control since they do not require any strange tool to be 
>>>>> built.
>>>> They require an i386 cross compiler, which is not available on all
>>>> installations.
>>>
>>> They are being built always anyway now, since their target
>>> pc-bios/optionrom/linuxboot.bin does not exist on a checked out tree or
>>> even a release tree.  But no one has complained.
>>
>> They are only built on i386 and x86_64 hosts, look at the configure
>> script. We should continue providing all the ROM binaries, even the x86
>> ones.
>
> Oops, my bad. :-(  The only reason I see against my patch is that the option
> ROMS do not change that often; maybe I felt that it should be done different
> only because I screwed up and I'm blaming the code instead of myself.
> There is also the problem that they are not built on Darwin and Solaris,
> which is possibly even worse.
>
> What about adding to version control a stamp file and using it to avoid
> useless changes to pc-bios/*.bin?  Such as overwriting the .bin files only
> when the .S file changes.  Something like the attached patch.

configure could also detect that we are building inside the source
tree (not in an object tree outside of the source directory) and not
compile the roms in that case. Or we could make object tree use
mandatory, it's a good practice anyway.