qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices,


From: Amit Shah
Subject: [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports
Date: Thu, 7 Jan 2010 13:01:38 +0530

Hello,

This series addresses comments from last time:
- use ldl/stl instead of communicating in little endian.
- virtio-serial-bus is back in Makefile.target as a result of the above
  change.
- don't write to guest memory in handle_control_message
- is_console is a property; remove from custom debug output.
- reword FIXME comment for serial chardevs in qdev.c
- no need to maintain copy of guest_features

And a couple of other changes/bugfixes:
- Set serial ports to noncaching behaviour by default
- Ensure console input works in case of older kernel module
  (rebase artifact)

Obligatory disclaimer:
This series splits up the patches by functionality. Note, however,
that patches 2-6 introduce some functionality that's advertised to the
guest as having to work all at once or not at all. Also, the savevm
version is bumped only once but save/restore state is added in each of
the patches. They are split only for easier reviewability.

The older virtio-console.c file is completely removed and a new
virtio-serial.c is introduced so that reviewing is easier. I can send a
later patch to rename virtio-serial.c back to virtio-console.c.

Amit Shah (8):
  virtio: Remove duplicate macro definition for max. virtqueues, bump
    up the max
  virtio-console: qdev conversion, new virtio-serial-bus
  virtio-serial-bus: Maintain guest and host port open/close state
  virtio-serial-bus: Add a port 'name' property for port discovery in
    guests
  virtio-serial-bus: Add support for buffering guest output, throttling
    guests
  virtio-serial-bus: Add ability to hot-unplug ports
  virtio-serial: Add a 'virtserialport' device for generic serial port
    support
  Move virtio-serial to Makefile.hw

 Makefile.hw            |    2 +-
 Makefile.target        |    2 +-
 hw/pc.c                |   11 +-
 hw/ppc440_bamboo.c     |    7 -
 hw/qdev.c              |   10 +-
 hw/s390-virtio-bus.c   |   17 +-
 hw/s390-virtio-bus.h   |    2 +
 hw/s390-virtio.c       |    8 -
 hw/virtio-console.c    |  143 --------
 hw/virtio-console.h    |   19 -
 hw/virtio-pci.c        |   13 +-
 hw/virtio-serial-bus.c |  952 ++++++++++++++++++++++++++++++++++++++++++++++++
 hw/virtio-serial.c     |  151 ++++++++
 hw/virtio-serial.h     |  227 ++++++++++++
 hw/virtio.c            |    2 -
 hw/virtio.h            |    4 +-
 qemu-options.hx        |    4 +
 sysemu.h               |    6 -
 vl.c                   |   17 +-
 19 files changed, 1378 insertions(+), 219 deletions(-)
 delete mode 100644 hw/virtio-console.c
 delete mode 100644 hw/virtio-console.h
 create mode 100644 hw/virtio-serial-bus.c
 create mode 100644 hw/virtio-serial.c
 create mode 100644 hw/virtio-serial.h





reply via email to

[Prev in Thread] Current Thread [Next in Thread]