|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command |
| Date: | Thu, 31 Dec 2009 08:38:23 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 |
On 12/31/2009 12:46 AM, Anthony Liguori wrote:
I wasn't worried about that, only the increased code duplication.I wasn't thinking there would be an info ioapic command but rather a generic device-info command that would work with any qdev device. No code duplication (in fact, much, much less in the long term).
Machine printing isn't going to work. The information needs to be formatted to be legible and bit fields decoded. Some field's interpretation may depend on the value of others. In some case machine printing of vmstate will show you the history of that devices live migration bug fixes in addition to its state.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| [Prev in Thread] | Current Thread | [Next in Thread] |