Re: [Qemu-devel] [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports

[Markus Armbruster]

Anthony Liguori <address@hidden> writes:

> On 12/22/2009 11:49 AM, Amit Shah wrote:
>> This patch migrates virtio-console to the qdev infrastructure and
>> creates a new virtio-serial bus on which multiple ports are exposed as
>> devices. The bulk of the code now resides in a new file with
>> virtio-console.c being just a simple qdev device.
>>
>> This interface enables spawning of multiple virtio consoles as well as 
>> generic
>> serial ports.
>>
>> The older -virtconsole argument still works, but when using the new
>> functionality, it is recommended to use
>>
>>      -device virtio-serial-pci -device virtconsole,...
>>
>> The virtconsole device type accepts a chardev as an argument and a 'name'
>> argument to identify the corresponding consoles on the host as well as the
>> guest. The name, if given, is exposed via the 'name' sysfs attribute in the
>> guest.
>>
>> Care has been taken to ensure compatibility with kernels that do not
>> support multiple ports as well as accepting incoming migrations from older
>> qemu versions.
>>
>> Signed-off-by: Amit Shah<address@hidden>
>
> This is really difficult to review.  If you're introducing a
> completely new file, why don't you just call it virtio-serial.c and
> delete virtio-console.c  It will save quite a bit of reviewing head
> ache.

The patch series defines virtio-serial devices, one for PCI
(virtio-serial-pci, in virtio-pci.c) and one for s390
(virtio-serial-s390, in s390-virtio-bus.c).  The new file defines a
virtconsole device, and calling it virtio-serial would be confusing,
wouldn't it?