Re: [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

[Blue Swirl]

On Sat, Dec 19, 2009 at 3:58 PM, Aurelien Jarno <address@hidden> wrote:
> On Sat, Dec 19, 2009 at 04:34:22PM +0100, Aurelien Jarno wrote:
>> On Sat, Dec 19, 2009 at 03:19:02PM +0000, Blue Swirl wrote:
>> > On Sat, Dec 19, 2009 at 1:05 PM, Aurelien Jarno <address@hidden> wrote:
>> > > On Sat, Dec 19, 2009 at 10:08:43AM +0000, Blue Swirl wrote:
>> > >> On Sat, Dec 19, 2009 at 12:44 AM, Juan Quintela <address@hidden> wrote:
>> > >> > "Kirill A. Shutemov" <address@hidden> wrote:
>> > >> >> ping?
>> > >> >
>> > >> > Blue or Anthony, please apply.
>> > >> > Patch is needed to get libuser + pie working well.
>> > >>
>> > >> 0.12.0 has been tagged, but I think this is still good candidate
>> > >> material for 0.12.1.
>> > >>
>> > >
>> > > It doesn't seems to have been tagged yet.
>> >
>> > It's now. Anyway, I committed it to HEAD, please take it from there for 
>> > 0.12.1.
>> >
>>
>> Then the best is to commit it to stable-0.12, this will ensure it is in
>> 0.12.1.
>
> Actually it is not a good idea, as this patch breaks parallel building.
> It has to be fixed first:
>
> $ make -j2
> Makefile:5: config.mak: No such file or directory
> make[1]: *** No rule to make target `config.mak'.  Stop.
> make: *** [libuser.a] Error 2
> make: *** Waiting for unfinished jobs....

It's not parallel build (I thought so too at first) but any build
without -fpie. I committed a fix.