qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property
Date: Mon, 14 Dec 2009 15:56:38 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4

On 12/14/09 14:30, Markus Armbruster wrote:
Then the property parser would accepts strings such as 'bit1|bit2' and
you can have

   -device 'virtio-blk-pci,disable=blk-identify|ring-indirect'

The driver will just do 'vdev->host_features&= ~disable'.

Use of '|' in option argument syntax is user-hostile, because it
requires quoting in the shell.  What about '+'?

I don't care that much. I've picked '|' because it is 'or' in many programming languanges and thus sort of intuitive (at least to me). Using '+' is fine with me too.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]