[Qemu-devel] Re: [FOR 0.12 PATCH] scsi-disk: Inquiry with allocation length of CDB < 36 (v3)

[Blue Swirl]

On Sat, Dec 12, 2009 at 7:24 PM, Artyom Tarasenko
<address@hidden> wrote:
> According to the SCSI-2 specification,
> http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 ,
> "if the allocation length of the command descriptor block (CDB) is too
> small to transfer all of the parameters, the additional length shall
> not be adjusted to reflect the truncation."
> The 36 mandatory bytes of response are written to outbuf, and then
> only the length requested in CDB is transferred.
> ---
> Signed-off-by: Artyom Tarasenko <address@hidden>

Please leave out "---" between body and SoB in the future, now the SoB
is automagically dropped by git-am.

The patch applies cleanly, but:
  CC    scsi-disk.o
/src/qemu/hw/scsi-disk.c: In function 'scsi_disk_emulate_inquiry':
/src/qemu/hw/scsi-disk.c:441: error: 'len' undeclared (first use in
this function)
/src/qemu/hw/scsi-disk.c:441: error: (Each undeclared identifier is
reported only once
/src/qemu/hw/scsi-disk.c:441: error: for each function it appears in.)