[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() to QObject
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() to QObject |
Date: |
Thu, 10 Dec 2009 12:12:52 +0000 |
User-agent: |
Mutt/1.4.1i |
On Thu, Dec 10, 2009 at 09:56:06AM -0200, Luiz Capitulino wrote:
> On Thu, 10 Dec 2009 11:34:37 +0100
> Markus Armbruster <address@hidden> wrote:
>
> > > +/**
> > > + * do_info_vnc(): Show VNC server information
> > > + *
> > > + * Return a QDict with server information. Connected clients are returned
> > > + * as a QList of QDicts.
> > > + *
> > > + * The main QDict contains the following:
> > > + *
> > > + * - "status": "disabled" or "enabled"
> > > + * - "host": server's IP address
> > > + * - "service": server's port number
> > > + * - "auth": authentication method (optional)
> > > + * - "clients": a QList of all connected clients
> > > + *
> > > + * Clients are described by a QDict, with the following information:
> > > + *
> > > + * - "host": client's IP address
> > > + * - "service": client's port number
> > > + * - "x509 dname": TLS dname (optional)
> >
> > Sure you want dict keys with spaces? I'd prefer "x509-dname".
>
> I don't think it's a big deal because this string will never
> change, but would be good to come with a standard style for
> dict keys (at least for the protocol).
I agree with Markus, that it is nicer to avoid spaces in the dict keys,
even if technically it is allowed. I'd vote for x509-dname too.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
- [Qemu-devel] [PATCH 13/19] monitor: Convert do_info_mice() to QObject, (continued)
- [Qemu-devel] [PATCH 13/19] monitor: Convert do_info_mice() to QObject, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 14/19] migration: Convert do_info_migrate() to QObject, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 15/19] block: Convert bdrv_info() to QObject, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 16/19] block: Convert bdrv_info_stats() to QObject, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 17/19] char: Convert qemu_chr_info() to QObject, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 18/19] PCI: Convert pci_device_hot_add() to QObject, Luiz Capitulino, 2009/12/09
- [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() to QObject, Luiz Capitulino, 2009/12/09
- Re: [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions to QObject, Markus Armbruster, 2009/12/10