Re: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution

[Avi Kivity]

On 12/03/2009 02:33 PM, Glauber Costa wrote:
> On Thu, Dec 3, 2009 at 10:20 AM, Avi Kivity<address@hidden>  wrote:
>    
> > On 12/02/2009 03:48 PM, Glauber Costa wrote:
> >      
> > > This function is similar to qemu-kvm's on_vcpu mechanism.
> > >        
> > Is similar?  You're replacing on_vcpu().
> >      
> Yeah, it began similar, now it is pretty much the same thing, but
> using qemu-specific
> data structures
>    

Keep the name then.  The new name is misleading.

> > > Totally synchronous,
> > > and guarantees that a given function will be executed at the specified
> > > vcpu.
> > >
> > > This patch also convert usage within the breakpoints system
> > >
> > > +void qemu_queue_work(CPUState *env, void (*func)(void *data), void
> > > *data);
> > >
> > >        
> > The name suggests that it is asynchronous.
> >
> > Why is this patch necessary?
> >      
> to keep gdbstub working.
>    

"Because it fixes things".

Please elaborate.

--
error compiling committee.c: too many arguments to function