[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers instea
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers instead of just mp_state |
Date: |
Wed, 02 Dec 2009 13:35:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Gleb Natapov wrote:
> On Wed, Dec 02, 2009 at 01:10:22PM +0100, Jan Kiszka wrote:
>> Glauber Costa wrote:
>>>>> +{
>>>>> + if (kvm_enabled()) {
>>>> Is this ever called or intended to be called when kvm is disabled?
>>>>
>>>>> + kvm_cpu_flush_state(env);
>>>>> + }
>>> I don't think so. But this is here for consistency with its synchronize
>>> brother.
>> Ack. As soon as someone starts to use this generic service outside code
>> that is only built under CONFIG_KVM or called when kvm is enabled,
>> things will break.
>>
> We can add the check when adding first such user. Code outside
> CONFIG_KVM can't use this since the function is in kvm.h header.
> I don't have really strong opinion about that. I personally use
> kvm_enabled() as a hint that code is generic for kvm and non-kvm
> case when reading code.
It's the same case as with cpu_synchronize_state, just that the latter
is already used outside kvm code. Both services logically belong into a
different header but are in kvm.h for simplicity reasons.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH v2 06/11] flush state in migration post_load, (continued)
- [Qemu-devel] [PATCH v2 06/11] flush state in migration post_load, Glauber Costa, 2009/12/01
- [Qemu-devel] [PATCH v2 07/11] Don't call kvm cpu reset on initialization, Glauber Costa, 2009/12/01
- [Qemu-devel] [PATCH v2 08/11] use cpu_kick instead of direct signalling., Glauber Costa, 2009/12/01
- [Qemu-devel] [PATCH v2 09/11] Use per-cpu reset handlers., Glauber Costa, 2009/12/01
- [Qemu-devel] [PATCH v2 10/11] Use __thread where available., Glauber Costa, 2009/12/01
- [Qemu-devel] [PATCH v2 11/11] remove smp restriction from kvm, Glauber Costa, 2009/12/01
- Re: [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state, Gleb Natapov, 2009/12/02
- Re: [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state, Glauber Costa, 2009/12/02
- [Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers instead of just mp_state, Jan Kiszka, 2009/12/02
- [Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers instead of just mp_state, Gleb Natapov, 2009/12/02
- [Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers instead of just mp_state,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution, Marcelo Tosatti, 2009/12/02
- Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution, Glauber Costa, 2009/12/02
- Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution, Marcelo Tosatti, 2009/12/02
- Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution, Glauber Costa, 2009/12/02
Re: [Qemu-devel] [PATCH v2 0/11], Gleb Natapov, 2009/12/02