Re: [Qemu-devel] Fwd: qemu code review

[Blue Swirl]

On Wed, Nov 18, 2009 at 1:39 PM, Kevin Wolf <address@hidden> wrote:
> Hi all,
>
> as Steve suggests, I'm forwarding the list of issues he found to the
> mailing list. I've already looked at a few points in the block code and
> sent patches. If everyone picks up one point, we should get through the
> list quickly. Who volunteers for the TCG ones? ;-)

> In target-sparc/helper.c at line 1277, "name" has not be checked for
> non-NULL
> value before use.

The check is done earlier in sun4m.c, sun4u.c or *-user/main.c.
There's always code like this:
    if (!cpu_model)
        cpu_model = hwdef->default_cpu_model;
or
    if (cpu_model == NULL) {
...
#elif defined(TARGET_SPARC)
#ifdef TARGET_SPARC64
        cpu_model = "TI UltraSparc II";
#else
        cpu_model = "Fujitsu MB86904";
#endif

before any call to cpu_init().