Re: [Qemu-devel] [PATCH 02/11] Add operations to qlist to allow it to be used as a stack

[Anthony Liguori]

Kevin Wolf wrote:
> Am 11.11.2009 18:28, schrieb Anthony Liguori:
>   
> > This makes lists no longer invariant. It's a very useful bit of functionality
> > though.
> >
> > To deal with the fact that lists are no longer invariant, introduce a deep
> > copy mechanism for lists.
> >
> > Signed-off-by: Anthony Liguori <address@hidden>
> > ---
> >  qlist.c |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  qlist.h |    4 ++++
> >  2 files changed, 60 insertions(+), 0 deletions(-)
> >     
>
> So far all functions in qlist.c have a header comment. Any reason to
> change this?
>   

But nothing else in qemu does.

I don't find this commenting style particularly helpful since they 
really don't tell you anything you can't infer from the function name.  
I'm not opposed to people adding these types of comments but I don't 
think it's a good idea to attempt to enforce it in just this one place 
(not that I think it should be enforced everywhere).

Regards,

Anthony Liguori
> Kevin
>
>
>